Skip to content

fix: scope routing and support report-only plan audits - #2808

Draft
surim0n wants to merge 1 commit into
garrytan:mainfrom
surim0n:codex/astra-instruction-cleanup-20260905
Draft

fix: scope routing and support report-only plan audits#2808
surim0n wants to merge 1 commit into
garrytan:mainfrom
surim0n:codex/astra-instruction-cleanup-20260905

Conversation

@surim0n

@surim0n surim0n commented Sep 5, 2026

Copy link
Copy Markdown

Why (in your own words)

The proactive router treats weak keyword matches as a reason to invoke a skill, and an explicit read-only plan audit can enter the interactive decision workflow. This narrows routing to the requested outcome and gives explicit report-only audits a bounded path that returns findings and missing decisions without changing the plan or starting implementation. Interactive reviews and /autoplan keep their existing flow.

Live evidence

Pending: an actual model transcript demonstrating routing and report-only behavior before and after the change. This PR is a draft because automated tests do not satisfy that evidence requirement.

The following automated validation completed locally:

bun run gen:skill-docs --host all
npm exec --yes --package=bun@latest -- bun test test/gen-skill-docs.test.ts test/gen-skill-docs-idempotency.test.ts test/skill-ceo-section-ordering.test.ts test/catalog-budget.test.ts test/context-budget-ratchet.test.ts
436 pass
0 fail
6535 expect() calls
Ran 436 tests across 5 files.

The system Bun 1.2.18 lacked the YAML support needed by the tests; the final passing run used the current Bun package. This is test evidence, not live proof of model behavior.

Scope

  • Changed: root routing and CEO review source templates, plus their regenerated SKILL.md files.
  • Verified live by: local generation and the five focused automated test files listed above; no live model behavior claim.
  • Did NOT test: model-driven before/after behavior, interactive review sessions, or the complete test suite.

Liveness proof (required)

Pending a human-provided screenshot of GSTACK PR typed live into a real surface. No screenshot has been synthesized or submitted as human evidence.

Checklist

  • Liveness screenshot attached: GSTACK PR typed live into a real surface (not edited onto the image)
  • This is not a generated-file-only diff (I edited the source/template and regenerated)
  • No ETHOS.md edits, and no changes to voice / founder perspective / YC references
  • New public command / external service / host adapter has an accepted issue linked (N/A)
  • Linked issue or reproduction: pending live behavior reproduction

@trunk-io

trunk-io Bot commented Sep 5, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant